Add GitHub Actions & Upgrade to .NET 8 #380
Conversation
Adds configuration file for GitHub Actions for .NET 8.0 on windows-latest.
The serialization logic has changed in .NET 8 and the code needs to implement converters for complex type, such as System.Version.
Add specific Node version to use: 20.7.x Add front-end build step. Add manual Workflow dispatch.
JosefDvorak
added
bug
|
@JosefDvorak Not sure if you got this too, but I got this error when trying to run an action:
So I made a few changes in 268dfaf to resolve that, then a few other changes suggested by code analysis. Otherwise, it's all working and looks good 👍 Do we want to implement the automatic build+upload process as in https://github.com/kentico-ericd/KInspector/blob/master/.github/workflows/dotnet-desktop.yml? |
|
Thanks for catching that issue. Yes, implementing build is the next step, but I wanted to make sure the PR is as small as possible. So that will be for the next one, after this one is reviewed by you. I've tested the commits you made, and everything works fine, so I think we're ready to merge, if you approve. It looks like you already have most of the build script. Will you be able to update it for .NET 8 and make a PR, or would you like me to take that over? |
Motivation
The purpose of this PR is to add a minimum viable replacement for AppVeyor Build test using GitHub Actions Workflow
As part of the implementation, several issues were encountered that had to be addressed.
Checklist
How to test
Verify that project builds, reports execute and conduct code review.
For your reference, the GitHub Action Workflow has been tested on a mirror pull request on forked repository:
JosefDvorak#3